Compare commits

..

8 Commits

Author SHA1 Message Date
jaybe 8ad3a9e677 feat(zip): 루트 파일(extras) 포함 및 site.webmanifest JSON 검증 추가\n\n- favicon.ico/site.webmanifest/robots.txt ZIP 포함 지원\n- 잘못된 manifest JSON 시 에러\n- 테스트(phase4) 추가 및 통과
Auto PR / open-pr (push) Successful in 20s
Auto Label PR / add-automerge-label (pull_request) Successful in 6s
CI / test (pull_request) Successful in 55s
2025-11-15 00:11:05 +09:00
jaybe 678b081364 test(zip): 통합/메타 스냅샷 테스트 추가(exportPage+buildZip, SEO/OG/Analytics 보존)
Auto PR / open-pr (push) Successful in 21s
CI / test (pull_request) Failing after 11m23s
Auto Label PR / add-automerge-label (pull_request) Failing after 11m30s
2025-11-14 23:53:28 +09:00
jaybe 46a9c5c83d chore(ci): auto-pr.yml 충돌 해결 및 라벨 생성 금지 정책 유지 2025-11-14 23:52:16 +09:00
jaybe 6c86e1cf85 test(zip): Export ZIP 검증 강화(assets 유무/서브폴더 포함) 2025-11-14 23:45:08 +09:00
jaybe aaea43f2cc Merge pull request 'auto: PR for feat/sections-edge-cases' (#20) from feat/sections-edge-cases into main 2025-11-14 14:38:44 +00:00
jaybe bc29faf60c Merge pull request 'auto: PR for feat/sections-edge-cases' (#19) from feat/sections-edge-cases into main 2025-11-14 14:35:52 +00:00
jaybe 26a3b43d28 Merge pull request 'auto: PR for feat/exporter-dark-contrast' (#18) from feat/exporter-dark-contrast into main 2025-11-14 13:56:11 +00:00
jaybe 6ff27295e6 chore(ci): prevent duplicate 'automerge' creation — use existing label id only (auto-label/auto-pr)
Auto PR / open-pr (push) Successful in 29s
Auto Label PR / add-automerge-label (pull_request) Successful in 6s
CI / test (pull_request) Successful in 1m10s
2025-11-14 22:33:43 +09:00
6 changed files with 197 additions and 1 deletions
+1 -1
View File
@@ -69,7 +69,7 @@ jobs:
"${GITEA_BASE_URL}/api/v1/repos/${OWNER}/${NAME}/issues/${PR_NUMBER}/labels" \
-d '{"labels":['"${LID}"']}' || true
else
echo "No existing 'automerge' found; skip labeling"
echo "No existing 'automerge' label found; skipping label add"
fi
else
echo "PR number could not be determined; skipping label add"
+18
View File
@@ -5,6 +5,8 @@ export type BuildZipInput = {
css: string
js: string
assets?: Record<string, Uint8Array>
// root-level extra files like favicon.ico, site.webmanifest, robots.txt
extras?: Record<string, Uint8Array>
}
export async function buildZip(input: BuildZipInput): Promise<Uint8Array> {
@@ -19,6 +21,22 @@ export async function buildZip(input: BuildZipInput): Promise<Uint8Array> {
zip.file(path, buf as unknown as Buffer)
}
}
if (input.extras) {
// validate manifest if present
if (Object.prototype.hasOwnProperty.call(input.extras, 'site.webmanifest')) {
try {
const manifestBytes = input.extras['site.webmanifest']
const manifestStr = Buffer.from(manifestBytes).toString('utf8')
JSON.parse(manifestStr)
} catch {
throw new Error('Invalid site.webmanifest JSON')
}
}
for (const [path, bytes] of Object.entries(input.extras)) {
const buf = Buffer.from(bytes)
zip.file(path, buf as unknown as Buffer)
}
}
const content = await zip.generateAsync({ type: 'uint8array' })
return content
}
@@ -0,0 +1,53 @@
import { describe, it, expect } from 'vitest'
import JSZip from 'jszip'
import { exportPage } from '@/lib/exporter/html'
import { buildZip } from '@/lib/exporter/zip'
import { AssetManager } from '@/lib/assets/assetManager'
import { pageSchema, type Page } from '@/lib/schema/page'
function makePageWithLocalAsset(): { page: Page; am: AssetManager } {
const am = new AssetManager({ maxBytes: 1024 * 1024, allowedExts: ['png','svg','jpg','jpeg','webp'] })
// simulate adding a local image and referencing it by original name via local: prefix
const bytes = new Uint8Array([7,8,9])
// add as "hero.png"
am.add({ name: 'hero.png', type: 'image/png', bytes })
const base: Page = pageSchema.parse({
title: 'Integrated ZIP',
locale: 'en',
theme: { primaryColor: '#2563eb', fontFamily: 'Inter' },
sections: [
{ type: 'hero', props: { heading: 'Hello', subheading: 'World', imageUrl: 'local:hero.png' } },
{ type: 'cta', props: { text: 'Go', href: '#' } },
],
form: { actionUrl: '', fields: [], spamProtection: { honeypotFieldName: '_hp', minSubmitSeconds: 2 } },
analytics: { ga4MeasurementId: 'G-TEST', metaPixelId: '', customHeadHtml: '' },
seo: { title: 't', description: 'd' },
})
return { page: base, am }
}
describe('Export ZIP 통합 검증', () => {
it('exportPage 출력 + buildZip 결과에서 assets 경로/메타가 보존된다', async () => {
const { page, am } = makePageWithLocalAsset()
const out = exportPage(page, { assetManager: am })
const assets = am.toZipStructure()
const zipBytes = await buildZip({ html: out.html, css: out.css, js: out.js, assets })
const zip = await JSZip.loadAsync(zipBytes)
const names = Object.keys(zip.files)
// assets 파일이 존재해야 함
const assetKey = Object.keys(assets)[0]
expect(names).toContain(assetKey)
// index.html에 canonical/meta/ga4 스니펫 보존
const html = await zip.files['index.html'].async('string')
expect(html).toMatch(/<link rel="canonical" href="\//)
expect(html).toMatch(/<meta name="description" content="d"/)
expect(html).toMatch(/gtag\('config', 'G-TEST'\)/)
// hero 이미지가 재작성된 경로를 사용한다
const match = html.match(/<img[^>]*src="([^"]+)"/)
expect(match && match[1]).toBe(assetKey)
})
})
+28
View File
@@ -0,0 +1,28 @@
import { describe, it, expect } from 'vitest'
import JSZip from 'jszip'
import { buildZip } from '@/lib/exporter/zip'
describe('Export ZIP 메타 보존 검증', () => {
it('index.html의 SEO/OG/Analytics 메타가 그대로 보존된다', async () => {
const html = `<!DOCTYPE html><html><head>
<meta charset="utf-8" />
<link rel="canonical" href="/" />
<meta name="description" content="desc" />
<meta property="og:title" content="OT" />
<meta property="og:description" content="OD" />
<script>window.dataLayer=[];function gtag(){dataLayer.push(arguments);}gtag('js',new Date());</script>
</head><body>ok</body></html>`
const css = 'body{color:#222}'
const js = 'console.log("ok")'
const zipBytes = await buildZip({ html, css, js, assets: {} })
const zip = await JSZip.loadAsync(zipBytes)
const htmlContent = await zip.files['index.html'].async('string')
expect(htmlContent).toMatch(/<link rel="canonical" href="\//)
expect(htmlContent).toMatch(/<meta name="description" content="desc"/)
expect(htmlContent).toMatch(/<meta property="og:title" content="OT"/)
expect(htmlContent).toMatch(/<meta property="og:description" content="OD"/)
expect(htmlContent).toMatch(/window\.dataLayer=\[\];/)
})
})
@@ -0,0 +1,53 @@
import { describe, it, expect } from 'vitest'
import JSZip from 'jszip'
import { buildZip } from '@/lib/exporter/zip'
import type { BuildZipInput } from '@/lib/exporter/zip'
const TE = new TextEncoder()
describe('Export ZIP 검증 강화 4차: 루트 파일(favicon/manifest/robots)', () => {
it('루트 파일들을 포함한다: favicon.ico / site.webmanifest / robots.txt', async () => {
const manifest = {
name: 'Landing Builder',
short_name: 'LB',
start_url: '/',
display: 'standalone',
icons: [{ src: '/favicon.png', sizes: '512x512', type: 'image/png' }],
}
const input: BuildZipInput = {
html: '<!DOCTYPE html><html><head><title>a</title></head><body>ok</body></html>',
css: 'body{color:#111}',
js: 'console.log("ok")',
assets: {},
extras: {
'favicon.ico': new Uint8Array([0, 1, 2, 3]),
'site.webmanifest': TE.encode(JSON.stringify(manifest)),
'robots.txt': TE.encode('User-agent: *\nDisallow:'),
},
}
const zipBytes = await buildZip(input)
const zip = await JSZip.loadAsync(zipBytes)
const names = Object.keys(zip.files)
expect(names).toContain('favicon.ico')
expect(names).toContain('site.webmanifest')
expect(names).toContain('robots.txt')
const robots = await zip.files['robots.txt'].async('string')
expect(robots).toMatch(/User-agent: \*/)
const parsed = JSON.parse(await zip.files['site.webmanifest'].async('string'))
expect(parsed.name).toBe('Landing Builder')
expect(parsed.icons[0].type).toBe('image/png')
})
it('잘못된 manifest JSON이면 실패한다', async () => {
const badInput: BuildZipInput = {
html: '<!DOCTYPE html><html><head><title>a</title></head><body>ok</body></html>',
css: 'body{color:#111}',
js: 'console.log("ok")',
extras: { 'site.webmanifest': TE.encode('{ invalid json') },
}
await expect(buildZip(badInput)).rejects.toThrow()
})
})
+44
View File
@@ -0,0 +1,44 @@
import { describe, it, expect } from 'vitest'
import JSZip from 'jszip'
import { buildZip } from '@/lib/exporter/zip'
const TE = new TextEncoder()
describe('Export ZIP 검증 강화', () => {
it('assets가 비어있을 때 index.html/styles.css/app.js만 포함한다', async () => {
const zipBytes = await buildZip({
html: '<!DOCTYPE html><html><head><title>a</title></head><body>ok</body></html>',
css: 'body{color:#111}',
js: 'console.log("ok")',
assets: {},
})
const zip = await JSZip.loadAsync(zipBytes)
const names = Object.keys(zip.files).sort()
expect(names).toEqual(['app.js','index.html','styles.css'])
})
it('assets가 있으면 모든 파일을 그대로 포함한다(서브폴더 포함)', async () => {
const assets = {
'assets/img/logo.png': new Uint8Array([0,1,2,3]),
'assets/svg/icon.svg': TE.encode('<svg></svg>'),
'assets/fonts/inter.woff2': new Uint8Array([4,5,6]),
}
const zipBytes = await buildZip({
html: '<!DOCTYPE html><html><head><title>a</title></head><body>ok</body></html>',
css: 'body{color:#111}',
js: 'console.log("ok")',
assets,
})
const zip = await JSZip.loadAsync(zipBytes)
const names = Object.keys(zip.files)
expect(names).toContain('index.html')
expect(names).toContain('styles.css')
expect(names).toContain('app.js')
expect(names).toContain('assets/img/logo.png')
expect(names).toContain('assets/svg/icon.svg')
expect(names).toContain('assets/fonts/inter.woff2')
const logo = await zip.files['assets/img/logo.png'].async('uint8array')
expect(Array.from(logo)).toEqual([0,1,2,3])
})
})